Skip to content

Fix http url generation in awsxrayexporter #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2025

Conversation

bjrara
Copy link

@bjrara bjrara commented Jun 17, 2025

Description

When a request like http://localhost:8080/apitest?ip=myip&version=test is processed by awsxrayexporter, the generated http.request.url becomes http://localhost:8080/ip=myip&version=test.

Expected: http://localhost:8080/apitest?ip=myip&version=test

Link to tracking issue

Fixes
Integration tests

Testing

Unit test

Documentation

lisguo
lisguo previously approved these changes Jun 17, 2025
@lisguo
Copy link

lisguo commented Jun 17, 2025

Looks like unit tests are failing

=== FAIL: internal/translator TestSpanWithNotEnoughHTTPRequestURLAttributesStable (re-run 1) (0.00s)
    http_test.go:453: 
        	Error Trace:	/home/runner/work/opentelemetry-collector-contrib/opentelemetry-collector-contrib/exporter/awsxrayexporter/internal/translator/http_test.go:453
        	Error:      	Expected nil, but got: (*string)(0xc00047a550)
        	Test:       	TestSpanWithNotEnoughHTTPRequestURLAttributesStable

Paramadon
Paramadon previously approved these changes Jun 17, 2025
@lisguo lisguo self-requested a review June 17, 2025 21:31
@bjrara bjrara dismissed stale reviews from Paramadon and lisguo via 1db5b21 June 17, 2025 22:19
@Paramadon Paramadon merged commit c38f9eb into amazon-contributing:aws-cwa-dev Jun 18, 2025
150 checks passed
bjrara added a commit to aws-observability/aws-application-signals-test-framework that referenced this pull request Jun 18, 2025
*Issue description:*
The E2E test failed after fixing the http url generation in
awsxrayexporter.
PR:
amazon-contributing/opentelemetry-collector-contrib#323

*Description of changes:*
Add query parameters into trace assertion.

*Rollback procedure:*

<Can we safely revert this commit if needed? If not, detail what must be
done to safely revert and why it is needed.>

*Ensure you've run the following tests on your changes and include the
link below:*

To do so, create a `test.yml` file with `name: Test` and workflow
description to test your changes, then remove the file for your PR. Link
your test run in your PR description. This process is a short term
solution while we work on creating a staging environment for testing.

NOTE: TESTS RUNNING ON A SINGLE EKS CLUSTER CANNOT BE RUN IN PARALLEL.
See the
[needs](https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idneeds)
keyword to run tests in succession.
- Run Java EKS on `e2e-playground` in us-east-1 and eu-central-2
- Run Python EKS on `e2e-playground` in us-east-1 and eu-central-2
- Run metric limiter on EKS cluster `e2e-playground` in us-east-1 and
eu-central-2
- Run EC2 tests in all regions
- Run K8s on a separate K8s cluster (check IAD test account for master
node endpoints; these will change as we create and destroy clusters for
OS patching)

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 license.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants